12, not 8 char limit in testparm?

[David Collier-Brown -- Customer Engineering]

   It's indeed an error, and so should be fixed while
the older client programs are still in existance.
If we know what the clients were, that should be
mentioned in the message...

--dave

Christopher R. Hertel wrote:
> We have, in testparm, a test that looks something like the following:
> 
> if (strlen(lp_servicename(s)) > 8) {
>   printf("WARNING: You have some share names that are longer than 8 chars\n");
>   printf("These may give errors while browsing or may not be accessible\nto some older clients\n");
>   break;
>   }
> 
> (I fiddled the formatting because it fit badly in an 80-column message.)
> 
> Anyway, I think it should be 12, not 8 characters.  We know that the
> NetShareEnum() RAP call has a limit of 12 characters per share name.  Names
> longer than 12 characters (ASCII) are not returned by that call.  RPC-capable
> clients will send the NetrShareEnum() RPC call (note the extra 'r' in there)
> to retrieve share names longer than 12 characters.
> 
> Thoughts?
> 
> It's an easy change if folks think it should be corrected.
> 
> Chris -)-----
> 


-- 
David Collier-Brown,       | Always do right. This will gratify
Sun Microsystems,          | some people and astonish the rest.
Toronto, Ontario,          |                      -- Mark Twain
(905) 415-2849 or x52849   | davecb at canada.sun.com