CVS update: samba/source/passdb

Andrew Bartlett abartlet at
Fri Sep 12 00:56:02 GMT 2003

On Fri, 2003-09-12 at 02:52, jerry at wrote:
> Date:	Thu Sep 11 16:52:10 2003
> Author:	jerry
> Update of /data/cvs/samba/source/passdb
> In directory
> Modified Files:
>       Tag: SAMBA_3_0
> 	passdb.c pdb_ldap.c 
> Log Message:
> remove getpwnam() calls from init_sam_from_xxx().
> This means that %u & %g will no longer expand, but %U 
> and %G still do.  The payback is that winbindd local 
> accounts for users work with 'wbinfo -u' when winbind 
> is running on a PDC.

This was part of the 'ldap trust ids' thing (ie, part of the reason I
added it in the first place).  I wasn't aware that the getpwnam() had
crept back in there...

Anyway, we seem to have lost the ability to sub in the correct domain
(%D) (which could be different to the domain of the user currently
connected by SMB), and the loss of %u seems gratuitous.  (previously it
just mirrored %U, and we have the info still, so why kill it?)

I agree with removing calls to getpwnam() here - they really kill
performance, and break abstractions, but at the very least why not
simply remove the extra uid/gid arguments, and make alloc_sub_specified
work the same as alloc_sub_basic (ie, they call getpwnam() if they want
it, for %g and %G).

Andrew Bartlett

Andrew Bartlett                                 abartlet at
Manager, Authentication Subsystems, Samba Team  abartlet at
Student Network Administrator, Hawker College   abartlet at
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url :

More information about the samba-technical mailing list