Patch for utils/testparm.c in Samba 3.0.0 rc2

Alex Davis alex14641 at yahoo.com
Sat Sep 6 18:27:35 GMT 2003


 Hello
 
 I found a bug in testparm where it prints the wrong error message:
 I have 'map system = yes' in my smb.conf file and my create mask
 doesn't exclude the necessary bits in the create mask, but the 
 error message I get is:
 
 Map hidden can only work if create mask includes octal 010 (S_IXGRP).
 
 It should be:
 
 Map system can only work if create mask includes octal 010 (S_IXGRP).
 
 Here is a patch to fix the issue.
 
 --- utils/testparm.c.old      Fri Aug 15 16:40:01 2003
 +++ utils/testparm.c  Fri Aug 29 14:59:52 2003
 @@ -300,12 +300,12 @@
                         }
                         if (lp_map_system(s) && !(lp_create_mask(s) & S_IXGRP)) {
                                 printf("Invalid combination of parameters for service %s. \
 -                                          Map hidden can only work if create mask includes
 octal
 010 (S_IXGRP).\n",
 +                                          Map system can only work if create mask includes
 octal
 010 (S_IXGRP).\n",
                                            lp_servicename(s) );
                         }
                         if (lp_map_system(s) && (lp_force_create_mode(s) & S_IXGRP)) {
                                 printf("Invalid combination of parameters for service %s. \
 -                                          Map hidden can only work if force create mode
 excludes
 octal 010 (S_IXGRP).\n",
 +                                          Map system can only work if force create mode
 excludes
 octal 010 (S_IXGRP).\n",
                                            lp_servicename(s) );
                         }
                 }
 
 
 

=====
I code, therefore I am

__________________________________
Do you Yahoo!?
Yahoo! SiteBuilder - Free, easy-to-use web site design software
http://sitebuilder.yahoo.com



More information about the samba-technical mailing list