CVS update: samba/source/nsswitch

Andrew Bartlett abartlet at
Sat Sep 6 12:45:34 GMT 2003

On Fri, 2003-09-05 at 14:46, jerry at wrote:
> Date:	Fri Sep  5 04:46:44 2003
> Author:	jerry
> Update of /data/cvs/samba/source/nsswitch
> In directory
> Modified Files:
>       Tag: SAMBA_3_0
> 	winbindd_ads.c 
> Log Message:
> should fix bug 364 & 311:  Retry patch based on suggestion from 
> Ken Cross.  Sometimes ads conenction get stale but we don't know 
> they are dead until we try them. This patch may need some optimization
> after people bang on it for a while.

I'm a little stumped to tell how this patch actually changes behaviour:
  - the patch simply calls ads_retry_search() 2 times, on error. 
ads_retry_search already has an (apparently identical) loop, looping up
to 3 times on error.  

Do we really need to try 6 times to get a good answer - and shouldn't
this all just be in ads_retry_search?  Also, shouldn't we be keying off
the fact that the server was down somewhere there, and not just retry
for any failure (including compleatly invalid searches etc).

Andrew Bartlett

Andrew Bartlett                                 abartlet at
Manager, Authentication Subsystems, Samba Team  abartlet at
Student Network Administrator, Hawker College   abartlet at
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url :

More information about the samba-technical mailing list