SSVAL misuse in cmd_spoolss.c?
jra at samba.org
Mon Oct 20 21:00:15 GMT 2003
On Mon, Oct 20, 2003 at 08:47:20AM -0400, daniel.jarboe at custserv.com wrote:
> In cmd_spoolss.c:
> info->dependentfiles[i] = SSVAL(&info->dependentfiles[i], 0, str2[i]);
> I believe this assignment shouldn't be taking place, and it is unlike
> other usages of SSVAL throughout the code. This line is in both samba
> 2.2.8a and 3.0.0. The assignment affects s390 platforms (maybe
> others?), causing rpcclient adddriver dependentfiles to be filled with
> nulls. See bug #501. Taking out the assignment did not break intel,
> and fixed the problem for s390. Patch attached.
Yep - good catch - thanks ! Fixed in CVS.
More information about the samba-technical