get quota command bugs?

[Stefan Metzmacher]

Jelmer Vernooij wrote:

> Hi Rene,
> 
> On Wed, Oct 01, 2003 at 06:10:34AM +0200, Ren? Nieuwenhuizen wrote about 'get quota command bugs?':
> 
>>First of all: Thanks Samba-Team for a job well-done on Samba-3.0.0 (nice
>>new features)
> 
> 
>>Now some problems:
> 
> 
>>2. The man page of smb.conf seems to imply that the output of the "get
>>quota command" should be returned as one result per line. This is
>>wrong: all results must be returned on one line comma seperated.
> 
> It looks like spaces and possibly other characters are allowed as
> well. I'll have a closer look at this one tomorrow.
Sorry here's the patch...


Here're a new patch for updating the quota docs.
I added a note that this parameter's are a only avalable when ./configure --with-sys-quotas was used
or ./configure --with-quotas on linux.


-- 

metze

-------------------------------------------
Stefan (metze) Metzmacher <metze at metzemix.de>


-------------- next part --------------
Index: getquotacommand.xml
===================================================================
RCS file: /cvsroot/samba/docs/docbook/smbdotconf/vfs/getquotacommand.xml,v
retrieving revision 1.1.2.2
diff -u -r1.1.2.2 getquotacommand.xml
--- getquotacommand.xml	15 Aug 2003 16:22:18 -0000	1.1.2.2
+++ getquotacommand.xml	6 Oct 2003 05:48:48 -0000
@@ -7,6 +7,10 @@
 	whenever there is no operating system API available from the OS that 
 	samba can use.</para>
 
+	<para>This option is only available with <command>./configure --with-sys-quotas</command>.
+	Or on linux when <command>./configure --with-quotas</command> was used and a working quota api 
+	was found in the system.</para>
+
 	<para>This parameter should specify the path to a script that 
 	queries the quota information for the specified 
 	user/group for the partition that 
@@ -29,17 +33,18 @@
 		<listitem><para>4 - group default quotas (gid = -1)</para></listitem>
 	</itemizedlist>
 
-	<para>This script should print its output according to the following format:</para>
+	<para>This script should print its output according to the following format
+	      (on one line with space seperation):</para>
 
 	<itemizedlist>
-		<listitem><para>Line 1 - quota flags (0 = no quotas, 1 = quotas enabled, 2 = quotas enabled and enforced)</para></listitem>
-		<listitem><para>Line 2 - number of currently used blocks</para></listitem>
-		<listitem><para>Line 3 - the softlimit number of blocks</para></listitem>
-		<listitem><para>Line 4 - the hardlimit number of blocks</para></listitem>
-		<listitem><para>Line 5 - currently used number of inodes</para></listitem>
-		<listitem><para>Line 6 - the softlimit number of inodes</para></listitem>
-		<listitem><para>Line 7 - the hardlimit number of inodes</para></listitem>
-		<listitem><para>Line 8(optional) - the number of bytes in a block(default is 1024)</para></listitem>
+		<listitem><para>Arg 1 - quota flags (0 = no quotas, 1 = quotas enabled, 2 = quotas enabled and enforced)</para></listitem>
+		<listitem><para>Arg 2 - number of currently used blocks</para></listitem>
+		<listitem><para>Arg 3 - the softlimit number of blocks</para></listitem>
+		<listitem><para>Arg 4 - the hardlimit number of blocks</para></listitem>
+		<listitem><para>Arg 5 - currently used number of inodes</para></listitem>
+		<listitem><para>Arg 6 - the softlimit number of inodes</para></listitem>
+		<listitem><para>Arg 7 - the hardlimit number of inodes</para></listitem>
+		<listitem><para>Arg 8(optional) - the number of bytes in a block(default is 1024)</para></listitem>
 	</itemizedlist>
 
 	<para>See also the <link linkend="SETQUOTACOMMAND"><parameter moreinfo="none">set quota command</parameter></link> parameter.
Index: setquotacommand.xml
===================================================================
RCS file: /cvsroot/samba/docs/docbook/smbdotconf/vfs/setquotacommand.xml,v
retrieving revision 1.1.2.1
diff -u -r1.1.2.1 setquotacommand.xml
--- setquotacommand.xml	15 Aug 2003 16:31:06 -0000	1.1.2.1
+++ setquotacommand.xml	6 Oct 2003 05:48:48 -0000
@@ -7,6 +7,10 @@
 	whenever there is no operating system API available from the OS that 
 	samba can use.</para>
 
+	<para>This option is only available with <command>./configure --with-sys-quotas</command>.
+	Or on linux when <command>./configure --with-quotas</command> was used and a working quota api 
+	was found in the system.</para>
+
 	<para>This parameter should specify the path to a script that 
 	can set quota for the specified arguments.</para>
 
@@ -30,7 +34,7 @@
 		<listitem><para>8(optional) - block size, defaults to 1024</para></listitem>
 	</itemizedlist>
 
-	<para>The script should output at least one line of data.</para>
+	<para>The script should output at least one line of data on success. And nothing on failure.</para>
 
 	<para>See also the <link linkend="GETQUOTACOMMAND"><parameter moreinfo="none">get quota command</parameter></link> parameter.
 	</para>