Configure test in lib/sysquotas.c

[Andrew Bartlett]

On Sun, 2003-10-05 at 10:05, Jelmer Vernooij wrote:
> Hi, 
> 
> Why is there a configure test in the bottom of lib/sysquotas.c? Can't
> it be in a seperate file in the test/ directory? Currently, the basic structure 
> of the file is :
> 
> #ifndef AUTOCONF_TEST
> /* sysquota functionality */
> 
> #else 
> 	/* testcase for configure, including main() */ 
> #endif
> 
> Which is (imho) very ugly. This way we're doing two compiles
> on this file (once in configure, once in the make process) and there
> already is a seperate directory for large configure tests.
> 
> What do you think about moving it?

The usual reason for this structure is to allow the test-portion to
depend on the 'normal' portion.  This file is indeed a mess, and if it
does not follow that modal, then I think there is a very good case for
shifting it...

> Jelmer
-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20031005/cb8fde9f/attachment.bin