[PATCH CIFS] use CryptoAPI MD4/MD5

Matt Mackall mpm at selenic.com
Sat Oct 4 18:24:17 GMT 2003

On Sat, Oct 04, 2003 at 11:00:01AM -0700, dean gaudet wrote:
> what about CryptoAPI is so expensive that you can't use a stack-based
> context?

The alloc functions hide a bunch of module lookup details and the size
of the context structures vary from one alg to the next. They also
tend to hide block-sized buffers to deal with fragments. So it's a
little ugly but not insurmountable.

> this seems pretty dumb converting a stack-based md5 context to multiple
> instances in multiple structures.
> the stack is almost guaranteed to be in L1 cache.
> multiplying that structure by N connections is just a waste of memory
> bandwidth.  not to mention the locking crud you seem to need to do... the
> stack is implicitly locked.
> is CryptoAPI really this broken?

It's a bit inflexible in this regard, yes.

Matt Mackall : http://www.selenic.com : of or relating to the moon

More information about the samba-technical mailing list