[PATCH CIFS] use CryptoAPI MD4/MD5

Matt Mackall mpm at selenic.com
Wed Oct 1 19:55:22 GMT 2003


On Wed, Oct 01, 2003 at 03:30:39PM +0200, Erlend Aasland wrote:

>  static int cifs_calculate_signature(const struct smb_hdr * cifs_pdu, const char * key, char * signature)
[...]

> +	spin_lock(&md5_tfm_lock);
> +	crypto_digest_init(md5_tfm);
> +	crypto_digest_update(md5_tfm, sg, 2);
> +	crypto_digest_final(md5_tfm, signature);
> +	spin_unlock(&md5_tfm_lock);

Eek. How often does this get called? We're now up to three instances
of CryptoAPI conversion (/dev/random, cryptoloop, and cifs) that want
tfms-on-the-stack but instead use extra locking.

-- 
Matt Mackall : http://www.selenic.com : of or relating to the moon



More information about the samba-technical mailing list