fix for bug 802, dos attributes messing up group perms with acls

Jeremy Allison jra at
Tue Nov 25 22:54:40 GMT 2003

On Tue, Nov 25, 2003 at 11:41:05AM -0700, Jim McDonough wrote:
> Here is a proposed patch for fixing bug #802.  It retrieves the owning
> group perm bits from the ACL after stat(), so that when we do a
> fchmod_acl() the correct group perms are set.  The one thing that is
> missing is figuring out wheter there is even an ACL to retrieve it
> from...suggestions?
> Jeremy, can you please take a look at it?
> (See attached file: dosmode.patch)

This looks ok - if there's no ACL the initial fetch will fail,
but you're not checking the return code for the function so that's
not a problem. We do something similar in the fchmod_acl code.

I'll apply this, thanks.


More information about the samba-technical mailing list