CVS update: samba4/source/ntvfs

[Jelmer Vernooij]

Hi Metze,

On Tue, Nov 25, 2003 at 08:27:18AM +0100, Stefan Metzmacher wrote about 'Re: CVS update: samba4/source/ntvfs':
> Jelmer Vernooij wrote:
> >Date:	Tue Nov 25 03:15:26 2003
> >Author:	jelmer

> >Update of /home/cvs/samba4/source/ntvfs
> >In directory dp.samba.org:/tmp/cvs-serv11841/ntvfs

> >Modified Files:
> >	ntvfs_base.c 
> >Log Message:

> >Update to the modules system. Fixed:
> > - get rid of smb_probe_module
> > - merge older updates from 3.0
> > - introduced register_subsystem() and register_backend() functions
> > - adapt ntvfs and charset to use new register functions
> > - made smb_load_modules() work recursively (e.g. 'preload modules = 
> > /usr/lib/samba')
> > - got rid of some old remains

> >Things that still need work:
> > - Did I break tankFS? I don't think so, but I can't test it here :-(
> > - Add 'postload modules = ' (for modules that need to be loaded after 
> > fork() in smbd, if applicable)
> > - Convert RPC, auth, passdb, etc to use new 
> > register_{subsystem,backend}() functions
> > - Accept wildcards in 'preload modules' option, instead of loading 
> > recursively
> Patch looks good!:-)
Thanks!

> but one thing I'd like to see is

>  /* the ntvfs operations structure - contains function pointers to
>     the backend implementations of each operation */
>  struct ntvfs_ops {
> +	int version;
> 	const char *name;
> 	enum ntvfs_type type;

>  	/* initial setup */
Isn't that what the ntvfs_interface_version function is supposed to
be used for? A backend can check only the sizes of the structs it uses
and ignore the other ones.

Jelmer

-- 
Jelmer Vernooij                                              <jelmer at samba.org>
http://samba.org/~jelmer/                             http://samba.vernstok.nl/
Bugs in bugzilla: 15 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.samba.org/archive/samba-technical/attachments/20031125/a4c8cdd3/attachment.bin