Some errors... (SIGNING ERRORS)

[Stefan Metzmacher]

Hi Jeremy,

I this patch worked for me...

But the code you later commited to CVS didn't work for me I still got
signing errors with oplock breaks or something like this!

For now I have disabled signing, but it would be nice to have this fixed.

thanks

metze

Jeremy Allison wrote:
> On Mon, Oct 20, 2003 at 11:14:53AM +0200, Stefan Metzmacher wrote:
> 
>>I reproduced this also with win 2k sp4 :-)
>>
>>
>>here's a log-file and a cap-file
>>
>>the oplock-break seem to make the problem
>>
>>Locking AndX Request
>>
>>seq = 61
> 
> 
> Ok, can you try this patch please ? I think my "deferred packet"
> entry in the signing code isn't neccessary. I know why I added
> it, and I'm going over my test cases to make sure I can take it out.
> 
> In the meantime please try this patch.

> Index: libsmb/smb_signing.c
> ===================================================================
> RCS file: /data/cvs/samba/source/libsmb/smb_signing.c,v
> retrieving revision 1.4.2.37
> diff -u -r1.4.2.37 smb_signing.c
> --- libsmb/smb_signing.c        14 Oct 2003 17:01:03 -0000      1.4.2.37
> +++ libsmb/smb_signing.c        20 Oct 2003 23:55:01 -0000
> @@ -721,7 +721,11 @@
>                  * isn't a reply pending we need to re-sync the sequence
>                  * number.
>                  */
> +#if 1 /* JRATEST */
>                 if (is_oplock_break(inbuf) && !is_reply_pending(data->outstanding_packet_list))
> +#else
> +               if (is_oplock_break(inbuf))
> +#endif
>                         data->send_seq_num++;
>         }
> 
> @@ -832,8 +836,13 @@
>         if (!data)
>                 return;
> 
> +#if 1 /* JRATEST */
> +       store_sequence_for_reply(&data->outstanding_packet_list,
> +                                mid, data->send_seq_num, True);
> +#else
>         store_sequence_for_reply(&data->outstanding_packet_list,
>                                  mid, data->send_seq_num, deferred_packet);
> +#endif
>         data->send_seq_num++;
>  }
> 


-- 

metze

-------------------------------------------
Stefan (metze) Metzmacher <metze at metzemix.de>