keep generated code in Samba4?
simo.sorce at xsec.it
Thu Nov 20 10:19:47 GMT 2003
On Thu, 2003-11-20 at 07:00, tridge at samba.org wrote:
> We now have around 50k lines of generated RPC code in Samba4, and its
> growing fast. It might make sense to not put this code in CVS, and
> instead rely on all developers having the pidl IDL compiler installed,
> or possibly even including pidl in the Samba4 cvs tree (pidl is much
> smaller than the code it generates).
> Anyone have any special reason one way or the other? Up to now we have
> not relied on perl to build Samba, but perhaps that should change. For
> example a perl mkproto would probably be much faster and neater than
> our current awk one, and perl could be useful in some other parts of
> the build.
Currently I had the same issue with HEAD, I added the genstruct stuff
modified for samba, but as HEAD never happened to be perl dependent I
also made a new target in Makefile so that the developer can build the
needed headers and commit them.
Not putting the generated code into the samba4 cvs is wise, as what we
must rely on is _only_ the idl, or you would risk some commit not in
line with the idls.
But if you do that you should also include pidl in the samba4 cvs unless
it becomes a separate package available for most distributions.
> We might also decide to use an interim method, where we do not put the
> generated code in CVS, but we generate the code on samba.org before
> each release, so releases have the full generated code but developers
> who use cvs need to have pidl.
This is "the classic" way adopted in samba, but this time the amount of
code is so mush that putting pidl into samba4 is preferable imho.
> PS: If anyone is tempted to say "use XXX instead of perl", then the
> answer is that you first have to demonstrate a full rewrite of pidl in
> the XXX language. I think you may not find that easy, no matter how
> wonderful you think XXX is.
So what's the web site of this new language called XXX ? ;-)
Simo Sorce - simo.sorce at xsec.it
Xsec s.r.l. - http://www.xsec.it
via Durando 10 Ed. G - 20158 - Milano
mobile: +39 329 328 7702
tel. +39 02 2399 7130 - fax: +39 02 700 442 399
More information about the samba-technical