[PATCH] fix munged dial crash

Andrew Bartlett abartlet at samba.org
Tue Nov 11 23:36:46 GMT 2003

On Wed, 2003-11-12 at 09:19, Stefan Metzmacher wrote:
> Andrew Bartlett wrote:
> > On Wed, 2003-11-12 at 06:19, Gerald (Jerry) Carter wrote:
> > 
> >>Hash: SHA1
> >>
> >>Stefan Metzmacher wrote:
> >>| Hi,
> >>|
> >>| here's a small patch that prevents smbd from panic when the munged dial
> >>| field is empty like in pdb_ldap now.
> >>
> >>Thanks.  Got it.
> > 
> > 
> > I'm worried about some of the strlen(NULL) things we are still doing
> > (inside the base64 conversion routines), so this patch avoids the issue
> > a bit more.
> the munged_dial is PDB_NOT_QUIET_NULL so strlen("")

Grr..  I wish I never did that...

> but this patch is more readable, so apply it if it runs for you

My test rig is bust at the moment, so I'll get to it when I get my
VMware back up...


Andrew Bartlett

Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20031112/0e48113b/attachment.bin

More information about the samba-technical mailing list