[PATCH] some fixes

Stefan Metzmacher metze at metzemix.de
Tue Nov 11 22:00:20 GMT 2003


Hi,

can someone please apply this little fixes?

-- 

metze

-------------------------------------------
Stefan (metze) Metzmacher <metze at metzemix.de>

-------------- next part --------------
Index: lib/system.c
===================================================================
RCS file: /cvsroot/samba/source/lib/system.c,v
retrieving revision 1.78.2.9
diff -u -r1.78.2.9 system.c
--- lib/system.c	1 Oct 2003 17:01:21 -0000	1.78.2.9
+++ lib/system.c	11 Nov 2003 21:06:21 -0000
@@ -449,6 +449,8 @@
 		DEBUG(1,("WARNING: no chown!\n"));
 		done=1;
 	}
+	errno = ENOSYS;
+	return -1;
 #else
 	return(chown(fname,uid,gid));
 #endif
Index: rpc_server/srv_srvsvc_nt.c
===================================================================
RCS file: /cvsroot/samba/source/rpc_server/srv_srvsvc_nt.c,v
retrieving revision 1.70.2.15
diff -u -r1.70.2.15 srv_srvsvc_nt.c
--- rpc_server/srv_srvsvc_nt.c	19 Sep 2003 21:57:43 -0000	1.70.2.15
+++ rpc_server/srv_srvsvc_nt.c	11 Nov 2003 21:07:03 -0000
@@ -490,7 +490,7 @@
 	pstring net_name;
 
 	pstrcpy(net_name, lp_servicename(snum));
-	return (net_name[strlen(net_name)] == '$') ? True : False;
+	return (net_name[strlen(net_name)-1] == '$') ? True : False;
 }
 
 /*******************************************************************
Index: lib/fault.c
===================================================================
RCS file: /cvsroot/samba/source/lib/fault.c,v
retrieving revision 1.11.2.2
diff -u -r1.11.2.2 fault.c
--- lib/fault.c	20 Aug 2003 17:13:36 -0000	1.11.2.2
+++ lib/fault.c	11 Nov 2003 21:08:35 -0000
@@ -74,6 +74,9 @@
 #ifdef SIGBUS
 	CatchSignal(SIGBUS,SIGNAL_CAST sig_fault);
 #endif
+#ifdef SIGARBT
+	CatchSignal(SIGABRT,SIGNAL_CAST sig_fault);
+#endif
 }
 
 
Index: lib/util_str.c
===================================================================
RCS file: /cvsroot/samba/source/lib/util_str.c,v
retrieving revision 1.47.2.45
diff -u -r1.47.2.45 util_str.c
--- lib/util_str.c	3 Nov 2003 14:34:24 -0000	1.47.2.45
+++ lib/util_str.c	11 Nov 2003 21:09:37 -0000
@@ -574,7 +574,7 @@
 	size_t len;
 
 	if (!dest) {
-		DEBUG(0,("ERROR: NULL dest in safe_strcpy\n"));
+		DEBUG(0,("ERROR: NULL dest in safe_strcpy, called from [%s][%d]\n",fn,line));
 		return NULL;
 	}
 
@@ -610,7 +610,7 @@
 	size_t src_len, dest_len;
 
 	if (!dest) {
-		DEBUG(0,("ERROR: NULL dest in safe_strcat\n"));
+		DEBUG(0,("ERROR: NULL dest in safe_strcat, called from [%s][%d]\n",fn,line));
 		return NULL;
 	}
 
@@ -654,7 +654,7 @@
 #endif
 
 	if (!dest) {
-		DEBUG(0,("ERROR: NULL dest in alpha_strcpy\n"));
+		DEBUG(0,("ERROR: NULL dest in alpha_strcpy, called from [%s][%d]\n",fn,line));
 		return NULL;
 	}
 
@@ -695,9 +695,11 @@
 	clobber_region(fn, line, dest, n+1);
 #endif
 
-	if (!dest)
+	if (!dest) {
+		DEBUG(0,("ERROR: NULL dest in StrnCpy, called from [%s][%d]\n",fn,line));
 		return(NULL);
-	
+	}
+
 	if (!src) {
 		*dest = 0;
 		return(dest);


More information about the samba-technical mailing list