[PATCH] TSE/munged dial : bugfix !

Andrew Bartlett abartlet at samba.org
Sat Nov 8 06:02:22 GMT 2003

On Sat, 2003-11-08 at 05:12, Jeremy Allison wrote:
> On Fri, Nov 07, 2003 at 11:50:31AM +0100, Aur?lien Degr?mont wrote:
> > Hi,
> > 
> > There is a problem with my previous patch concerning TSE. Only 2 of the 
> > four diff of the modified files were present.
> > Be aware that that buggy patch compiles without warnings and Samba run 
> > without complaining, but the data inside munged_dial are totally broken.
> > 
> > Here is the correct patch for it :)
> This patch has a few memry leaks and I don't like the interface
> to the blob stuff - but I've fixed this and will commit it
> soon.

Why is the 'samba internal data structure' base64 encoded?  Sure, TDBSAM
might like it that way, but why keep it in base64 for all users?  For
LDAP, we will probably find that native LDAP binary encoding makes more
sense (or at least follows conventions).

Andrew Bartlett

Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20031108/746919dc/attachment.bin

More information about the samba-technical mailing list