[PATCH] Upgrade for TDBSAM formatM

Simo idra at samba.org
Mon Nov 3 23:43:50 GMT 2003

On Mon, 2003-11-03 at 17:19, Aurélien Degrémont wrote:

> Here is the new version of the patch, updated for SAMBA_3_0 
> (samba-3.0.1-pre1).
> This patch only implements the versionning system of TDBSAM. I had a new 
> field (lockout_time) to the new TDBSAM datas only to test it.
> The new fields of TDBSAM v1 must be discuss. It's useless to apply this 
> patch if we must add others fields in few days/weeks that will compel to 
> create a other tdbformat (v2) just after this one (v1). I have already 
> talked about them here (lockout_time, nt_password, munged_dial).
> Except this, the patch is ok.

The patch seem ok indeed, only one question, why have you added
TDBSAM_VERSION when we already defined PDB_VERSION?
ok PDB_VERSION mistakenly is unused, but then remove it if you prefer

As I said the format to use for nt_passwrd should be at least a list of
NT HASHES comma separated in a string parameter. (If Andrew prefer some
other format let him patch the code, let's concentrate on getting the
code out right first :-)

Munged_dial may be stored as a base64 string of the blob received so
that it can also easily stored in a string.

Finally if you prepare this patch for HEAD then we can play with it
wothout caring about version numbers until the version stabilize as we
like. Then we will apply it to 3.0


Simo Sorce    -  idra at samba.org
Samba Team    -  http://www.samba.org
Italian Site  -  http://samba.xsec.it

More information about the samba-technical mailing list