Experimental read cache patches, part 4 of 4

jra at dp.samba.org jra at dp.samba.org
Thu May 29 17:49:31 GMT 2003

On Wed, May 28, 2003 at 10:07:11PM -0400, Dave Collier-Brown wrote:
> --- fileio.old.c        Tue May 27 20:05:13 2003
> +++ fileio.c    Wed May 28 21:37:09 2003
> @@ -23,6 +23,11 @@
>  #include "includes.h"
>  static BOOL setup_write_cache(files_struct *, SMB_OFF_T);
> +static BOOL setup_read_cache(files_struct *);
> +static int copy_from_cache(write_cache *, char *, size_t);
> +static int read_from_read_cache(files_struct *,char
> *,SMB_OFF_T,size_t);


	These patches are broken because your mailer wrapped
them at 80 columns. I know I'm being a pain here and could fix
these by hand but I really want to teach you how to submit
*working* patches that will apply without any difficulty.

Most of the time your work gets ignored because of errors like
this, not using diff -u, not using the correct CVS, not sending
patches as separate attachments (as in this case) and I'd
just like to point out how to do this *right* so you and others
won't keep getting things ignored.

a). Use current CVS and unidiff to generate patches against.
	Just do :

	cvs diff -u >/tmp/patchfile

	to create the patch.

b). Send patches as *attachments*, not as inline code. This
preserves all line boundaries etc.

I would really like to include this work, and I know Solaris
needs it due to the disk i/o issues, so please re-submit in
a way that makes this *easy* to apply and evaluate.

Sorry (Soapbox mode off :-).


More information about the samba-technical mailing list