[PATCH] remove -Wshadow from krb5-developer

Stefan (metze) Metzmacher metze at metzemix.de
Tue May 20 06:31:26 GMT 2003


At 20:51 19.05.2003 +0000, jra at dp.samba.org wrote:
>On Mon, May 19, 2003 at 10:03:12PM +0200, Stephan Kulow wrote:
> > Am Monday 19 May 2003 18:43 schrieb jra at dp.samba.org:
> > > On Mon, May 19, 2003 at 02:17:45PM +0200, Stefan (metze) Metzmacher 
> wrote:
> > > > Hi,
> > > >
> > > > I have a small fix to remove -Wshadow from --enable-krb5-developer
> > > >
> > > > to reduce the warnings on SuSE 8.2
> > >
> > > Nope - I *want* the warnings there. It may convince the Heimdal
> > > people to fix their code.
> > As a matter of fact: you can't hide paramters in prototypes. The message is
> > bogus and -Wshadow should be avoided.
>
>No, -Wshadow is useful in catching errors in the Samba code.
>It will remain turned on, I suggest you fix the header files.

Ok, but then we should remove --einable-krb5-developer completly!
The -Wstrict-prototype warnings should also be fixed in the heimdal and mit 
header files...



metze
-----------------------------------------------------------------------------
Stefan "metze" Metzmacher <metze at metzemix.de> 




More information about the samba-technical mailing list