PATCH: make auth plugins work again

[Jelmer Vernooij]

On Thu, May 15, 2003 at 08:42:47PM +1000, Luke Howard wrote about 'Re: PATCH: make auth plugins work again':

> Jelmer,

> Actually, talking of logic errors, this is actually a bit cleaner
> (avoiding !NT_STATUS_OK()):

> ...
> 	if (entry == NULL) {
> 		if (NT_STATUS_IS_OK(smb_probe_module("auth", module_name))) {
> 			entry = auth_find_backend_entry(module_name);
> 		}
> 	}

> 	if (entry != NULL) {
> 		if (NT_STATUS_IS_OK(entry->init(auth_context, module_params, ret))) {
> 			DEBUG(5,("load_auth_module: auth method %s has a valid init\n",
> 				 module));
> 			good = True;
> 		} else {
> 			DEBUG(0,("load_auth_module: auth method %s did not correctly init\n",
> 				 module));
> 		}
> 	} else {
> 		DEBUG(0,("load_auth_module: can't find auth method %s!\n", module_name));
> 	}
> ...

Thanks Luke,

I'll take a look at this in about two weeks, when my exams are over.

Jelmer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20030515/7007de72/attachment.bin