PATCH: make auth plugins work again
Luke Howard
lukeh at PADL.COM
Thu May 15 10:42:47 GMT 2003
Jelmer,
Actually, talking of logic errors, this is actually a bit cleaner
(avoiding !NT_STATUS_OK()):
...
if (entry == NULL) {
if (NT_STATUS_IS_OK(smb_probe_module("auth", module_name))) {
entry = auth_find_backend_entry(module_name);
}
}
if (entry != NULL) {
if (NT_STATUS_IS_OK(entry->init(auth_context, module_params, ret))) {
DEBUG(5,("load_auth_module: auth method %s has a valid init\n",
module));
good = True;
} else {
DEBUG(0,("load_auth_module: auth method %s did not correctly init\n",
module));
}
} else {
DEBUG(0,("load_auth_module: can't find auth method %s!\n", module_name));
}
...
-- Luke
P.S. I have an untested Active Directory/RFC 2307 idmap plugin available
at http://www.padl.com/download/xad_oss_plugins.tar.gz. As soon as the
idmap plugin API makes a SAMBA release I will test it. Also, the PAULA
authentication plugin has been updated for 3.0alpha24.
P.P.S. Has 3.0alpha24 become pickier about UTF-8? I had a few oddly
named files in my home directory, and until I removed them, SAMBA
would crash with:
[2003/05/15 20:35:37, 8] smbd/trans2.c:get_lanman2_dir_entry(517)
get_lanman2_dir_entry:readdir on dirptr 0x835d558 now at offset 76
[2003/05/15 20:35:37, 0] lib/iconv.c:utf8_pull(471)
short utf8 char
[2003/05/15 20:35:37, 0] lib/charcnv.c:convert_string_allocate(248)
Conversion error: Incomplete multibyte sequence(à)
[2003/05/15 20:35:37, 0] lib/util.c:smb_panic(1446)
smb_panic: clobber_region() last called from [mask_match(2337)]
[2003/05/15 20:35:37, 0] lib/util.c:smb_panic(1463)
PANIC: failed to create UCS2 buffer
[2003/05/15 20:35:37, 0] lib/util.c:smb_panic(1470)
BACKTRACE: 14 stack frames:
#0 bin/smbd(smb_panic+0x256) [0x81e1c1a]
#1 bin/smbd(unix_strlower+0x39) [0x81ca23d]
#2 bin/smbd(strlower_m+0x7f) [0x81d9307]
#3 bin/smbd(mask_match+0xe6) [0x81e3eae]
#4 bin/smbd [0x80ae423]
#5 bin/smbd [0x80b00c7]
#6 bin/smbd(reply_trans2+0x943) [0x80b82c7]
#7 bin/smbd [0x80cedaf]
#8 bin/smbd [0x80cee80]
#9 bin/smbd(process_smb+0x223) [0x80cf22b]
#10 bin/smbd(smbd_process+0x20c) [0x80cff78]
#11 bin/smbd(main+0x923) [0x824dcc7]
#12 /lib/libc.so.6(__libc_start_main+0xbb) [0x4027314f]
#13 bin/smbd(ldap_msgfree+0x65) [0x8072e21]
There was no problem in 3.0alpha23.
--
Luke Howard | PADL Software Pty Ltd | www.padl.com
More information about the samba-technical
mailing list