winbindd segfaulting

[jra at dp.samba.org]

On Wed, May 14, 2003 at 09:49:46AM +0200, Guenther Deschner wrote:
> apprently the same bug as
> 
> https://bugzilla.samba.org/show_bug.cgi?id=80
> 
> On Tue, May 13, 2003 at 01:52:15PM -0400, Roylance, Stephen D. wrote:
> > I've run into a new problem with winbindd segfaulting.  I'm running 3_0 from cvs
> > updated this morning.  I caught the segmentation fault with gdb, it is in line
> > 986 of rpc_client/cli_pipe.c:
> > auth_schannel = (cli->saved_netlogon_pipe_fnum != 0);
> > 
> > I took a backtrace as well:
> > (gdb) bt
> > #0  rpc_api_pipe_req (cli=0x7df243a6, op_num=13 '\r', data=0x2ff1fef8,
> > rdata=0xf0909058) at rpc_client/cli_pipe.c:986
> > #1  0x10096ea0 in cli_lsa_enum_trust_dom (cli=0xf0902730, mem_ctx=0x2ff20010,
> > pol=0xf08c18c0, enum_ctx=0x1, num_domains=0x2ff1fcd0, domain_names=0x100229a8,
> > domain_sids=0x2) at rpc_client/cli_lsarpc.c:653
> > #2  0x10096ea0 in cli_lsa_enum_trust_dom (cli=0x7df243a6, mem_ctx=0x20281ec8,
> > pol=0x200245e0, enum_ctx=0x2ff200fc, num_domains=0x2ff201c4,
> > domain_names=0x2ff201c8, domain_sids=0x2ff201d0) at rpc_client/cli_lsarpc.c:653
> > #3  0x100baf24 in trusted_domains (domain=0xd, mem_ctx=0x20281ec8,
> > num_domains=0x2ff201c4, names=0x2ff201c8, alt_names=0x200245dc,
> > dom_sids=0x2ff201d0) at nsswitch/winbindd_rpc.c:716
> > #4  0x100b8fd4 in trusted_domains (domain=0x202a3408, mem_ctx=0x20281ec8,
> > num_domains=0x2ff201c4, names=0x2ff201c8, alt_names=0x2ff201cc,
> > dom_sids=0x2ff201d0) at nsswitch/winbindd_cache.c:982
> > #5  0x100445a4 in rescan_trusted_domains (force=1) at
> > nsswitch/winbindd_util.c:181
> > #6  0x100447fc in init_domain_list () at nsswitch/winbindd_util.c:224
> > #7  0x10043fc0 in domain_list () at nsswitch/winbindd_util.c:56
> > #8  0x1004485c in find_domain_from_name (domain_name=0x2ff20348 "PARTNERS") at
> > nsswitch/winbindd_util.c:238
> > #9  0x100bc5b4 in winbindd_getpwnam (state=0x20281ec8) at
> > nsswitch/winbindd_user.c:117
> > #10 0x10000d18 in process_request (state=0x2029a178) at nsswitch/winbindd.c:273
> > #11 0x10001178 in winbind_process_packet (state=0x2029a178) at
> > nsswitch/winbindd.c:397
> > #12 0x10001c00 in process_loop () at nsswitch/winbindd.c:694
> > #13 0x10002250 in main (argc=536903648, argv=0x20007fdc) at
> > nsswitch/winbindd.c:891
> > #14 0x100001dc in __start ()

This is the fix I think.

Index: nsswitch/winbindd_cm.c
===================================================================
RCS file: /data/cvs/samba/source/nsswitch/winbindd_cm.c,v
retrieving revision 1.31.2.22
diff -u -r1.31.2.22 winbindd_cm.c
--- nsswitch/winbindd_cm.c      8 May 2003 08:02:51 -0000       1.31.2.22
+++ nsswitch/winbindd_cm.c      14 May 2003 20:45:30 -0000
@@ -448,6 +448,8 @@
 {
        struct winbindd_cm_conn *conn, conn_temp;

+       *conn_out = NULL;
+
        for (conn = cm_conns; conn; conn = conn->next) {
                if (strequal(conn->domain, domain) &&
                    strequal(conn->pipe_name, pipe_name)) {


Jeremy.