[PATCH] smb_register_idmap()

Anthony Liguori aliguor at us.ibm.com
Wed May 14 15:25:29 GMT 2003

The code duplication is an unfortunate side effect of the way pdb_ldap is 
written.  The ldapsam_privates struct holds both info that pdb needs and 
that the ldap functions need.  pdb_ldap needs a bit of rewritting in order 
to share code between the two.  I can do this but I just need to be sure 
that pdb_ldap isn't going to change underneath me (which always seems to 

If we could get a day-long freeze of pdb_ldap, I could rework it to share 
code with idmap_ldap.

Anthony Liguori
Linux/Active Directory Interoperability
Linux Technology Center (LTC) - IBM Austin
E-mail: aliguor at us.ibm.com
Phone: (512) 838-1208
Tie Line: 678-1208

"Gerald (Jerry) Carter" <jerry at samba.org>
05/14/2003 08:24 AM

        To:     "Stefan (metze) Metzmacher" <metze at metzemix.de>
        cc:     idra at samba.org, Anthony Liguori/Austin/IBM at IBMUS, Andrew Bartlett 
<abartlet at samba.org>, <samba-technical at lists.samba.org>
        Subject:        Re: [PATCH] smb_register_idmap()

Hash: SHA1

On Wed, 14 May 2003, Stefan (metze) Metzmacher wrote:

> and a fixed version of idmap_ldap.c
> - but it needs to converted to the new schema system
> - and I'm not sure if there're some ldap_free_*()'s missing in some 
>    Anthony can you check that please.

I'll work on the idmap_ldap stuff on Monday.  I don't have time to fix 
and test it today.  That means 3.0alpha24  will go out short
of the idmap_ldap code but I'm ok with that.

At first glance, i think there is way too much duplication.  We 
should strip out the common functions from pdb_ldap.c and put them 
in a utility file to link with both idmap and passdb related code.

cheers, jerry
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: For info see http://quantumlab.net/pine_privacy_guard/


More information about the samba-technical mailing list