[PATCH] smb_register_idmap()

Andrew Bartlett abartlet at samba.org
Wed May 14 13:35:14 GMT 2003

On Wed, 2003-05-14 at 23:24, Gerald (Jerry) Carter wrote:
> Hash: SHA1
> On Wed, 14 May 2003, Stefan (metze) Metzmacher wrote:
> > and a fixed version of idmap_ldap.c
> > - but it needs to converted to the new schema system
> > - and I'm not sure if there're some ldap_free_*()'s missing in some places...
> >    Anthony can you check that please.
> I'll work on the idmap_ldap stuff on Monday.  I don't have time to fix 
> and test it today.  That means 3.0alpha24  will go out short
> of the idmap_ldap code but I'm ok with that.

I'm fine with that.  The (unsupported) sites that use non-algorithmic
RIDs dragged off an NT4 PDC will need to wait till it's done :-).

> At first glance, i think there is way too much duplication.  We 
> should strip out the common functions from pdb_ldap.c and put them 
> in a utility file to link with both idmap and passdb related code.

Agreed.  The request from idra was for a 'can't bust anything' patch -
because we were already after the feature freeze, and the last time this
was attempted we missed some code in the copy from pdb_ldap.c to ldap.c

Andrew Bartlett

Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20030514/315f14c1/attachment.bin

More information about the samba-technical mailing list