smb_register_*() fakes for nmbd ...
jelmer at samba.org
Wed May 7 20:25:37 GMT 2003
On Wed, May 07, 2003 at 08:11:29PM +0000, John H Terpstra wrote about 'Re: smb_register_*() fakes for nmbd ...':
> On Wed, 7 May 2003, Jelmer Vernooij wrote:
> > On Tue, May 06, 2003 at 02:35:21PM +0200, Stefan (metze) Metzmacher wrote about 'smb_register_*() fakes for nmbd ...':
> > > Hi Jelmer,
> > > here's the full patch for faking up smb_register_fn's for nmbd and
> > > friends...
> > I'm currently testing this patch. I wasn't happy with the way you
> > defined the HAVE_SMB_REGISTER_* defines. I think that should happen in
> > the C source file after which we include the inline functions.
> > Also, I'm not sure whether inline functions should be in a header file
> > or a source file. Any C gurus awake?
> I would prefer inline functions to be defined in the header files. There
> are no hard and fast rules for this. My suggestion is that if the inline
> function is that it will be used only in 1 module, it does not matter
> where you place it. If it will be used in many modules that is a clear
> argument for placing it in a header file.
The inline functions are only used by samba's own sources, and are not
and (should not) be used by the modules.
Jelmer Vernooij <jelmer at samba.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20030507/2d567275/attachment.bin
More information about the samba-technical