smb_register_*() fakes for nmbd ...

John H Terpstra jht at
Wed May 7 20:11:29 GMT 2003

On Wed, 7 May 2003, Jelmer Vernooij wrote:

> On Tue, May 06, 2003 at 02:35:21PM +0200, Stefan (metze) Metzmacher wrote about 'smb_register_*() fakes for nmbd ...':
> > Hi Jelmer,
> > here's the full patch for faking up smb_register_fn's for nmbd and
> > friends...
> Thanks metze,
> I'm currently testing this patch. I wasn't happy with the way you
> defined the HAVE_SMB_REGISTER_* defines. I think that should happen in
> the C source file after which we include the inline functions.
> Also, I'm not sure whether inline functions should be in a header file
> or a source file. Any C gurus awake?

I would prefer inline functions to be defined in the header files. There
are no hard and fast rules for this. My suggestion is that if the  inline
 function is that it will be used only in 1 module, it does not matter
where you place it. If it will be used in many modules that is a clear
argument for placing it in a header file.

- John T.
John H Terpstra
Email: jht at

More information about the samba-technical mailing list