New modules system and vfs_done

Stefan (metze) Metzmacher metze at metzemix.de
Mon Mar 31 10:43:24 GMT 2003


At 12:25 31.03.2003 +0200, Simo Sorce wrote:
>On Mon, 2003-03-31 at 03:30, Andrew Bartlett wrote:
> > As per my recent commit, the new (VFS) modules system completely breaks
> > on tree disconnect!
> >
> > We need to separate the different cases - the compat and the central
> > modules, and provide either a flag or a function pointer to the correct
> > way to shut down a module.

I have a patch for that, ab will look at it later this week.
It would be nice if you don't touch the vfs_done() function calls
(I want to remove the vfs_init() and vfs_done() fn's for the new modules)

and the shut down stuff should be in vfs_disconnect() !

> >
> > The code in conn_close is really in the wrong place - it's dealing with
> > the VFS, not the connection.
> >
> > And how should a internal module 'end' it's operations anyway?  We don't
> > seem to have that coded up at all...
>
>
>Eh, the shutdown stuff was just a thing, I was thinking yesterday ...
>I agree we should have to way to startup and shutdown the modules, as we
>have to way to load it (preload and fork).
>This is mandatory for modules that uses databases or other repository
>they connect to through a socket or other communication mechanism.


metze
-----------------------------------------------------------------------------
Stefan "metze" Metzmacher <metze at metzemix.de> 



More information about the samba-technical mailing list