[patch] uppercase workgroup in browse request

Richard Sharpe rsharpe at richardsharpe.com
Fri Mar 28 00:10:25 GMT 2003


On Thu, 27 Mar 2003, Stephan Kulow wrote:

> Am Thursday 27 March 2003 03:43 schrieb Christopher R. Hertel:
> > Stephan Kulow wrote:
> > > Hi!
> > >
> > > I noticed a difference between testsmbc "smb://MYGRP" and testsmbc
> > > "smb://mygrp" (it doesn't make a difference for SAMBA servers, but it
> > > does for XP and for winME) So please apply the included patch.
> >
> > Hang on...
> >
> > Do I read this correctly?  Are we forgetting to up-case the workgroup name?
> > (...it always helps to provide a little clue along with the patch.)  :)
> >
> > Samba decodes NetBIOS names and then performs a case-insensitive comparison
> > on the original name.  Windows (the versions I've tested) simply compares
> > the wire-format strings.  That's faster, but it's also case sensitive.  I
> > don't currently have any ME or XP systems to test.
> >
> I don't understand. You seem to agree with the patch, still it's not applied.

The patch has been applied. It has just not been pushed back to CVS yet 
:-)

Regards
-----
Richard Sharpe, rsharpe[at]ns.aus.com, rsharpe[at]samba.org, 
sharpe[at]ethereal.com, http://www.richardsharpe.com



More information about the samba-technical mailing list