BUG in auth_sam.c

[Stefan (metze) Metzmacher]

After, a bit more research, I can say the bug must be at an other place...
I'll try to fix it

At 12:48 26.03.2003 +0100, mx at metzemix.de wrote:
>Hi all,
>
>the pdb_* functions return NTSTATUS now!
>
>auth_sam.c line 430
>
><------------------------>
>         /* get the account information */
>
>         become_root();
>         ret = pdb_getsampwnam(sampass, user_info->internal_username.str);
>         unbecome_root();
>
>         if (ret == False)
>         {
>                 DEBUG(3,("Couldn't find user '%s' in passdb file.\n",
>user_info->internal_username.str));
>                 pdb_free_sam(&sampass);
>                 return NT_STATUS_NO_SUCH_USER;
>         }
><---------------------->
>
>Should be
>
><---------------------->
>         /* get the account information */
>         become_root();
>         nt_status = pdb_getsampwnam(sampass, 
> user_info->internal_username.str);
>         unbecome_root();
>
>         if (!NT_STATUS_IS_OK(nt_status)) {
>                 DEBUG(3,("Couldn't find user '%s' in passdb file.\n",
>user_info->internal_username.str));
>                 pdb_free_sam(&sampass);
>                 return nt_status;
>         }
><---------------------->
>
>BOOL ret should be removed!
>
>Sorry, I have no access to to a linux box now, so can't make a diff.
>
>metze


metze
-----------------------------------------------------------------------------
Stefan "metze" Metzmacher <metze at metzemix.de>