msdfs broken in 2.2.8

[jra at dp.samba.org]

On Mon, Mar 24, 2003 at 02:30:32PM -0800, Eric Horst wrote:
> 
> Hello!  With great enthusiasm I upgraded from 2.2.7a to 2.2.8 last week
> to get the critical security fix.  However, it appears that msdfs is
> broken in 2.2.8.  Several on the 'samba' list have reported this as
> well.  Some say it works OK for W2K but not for XP.  In my case I know
> it doesn't work for XP clients.  Testing, switching back and forth from
> 2.2.7a to 2.2.8 and using various clients it consistently confirms that
> 2.2.8 doesn't work.  I dug through logs, source and the 2.2.7a to 2.2.8
> diff and can't see any obvious change that would have broken it.  I've
> tried hard over the last few days to understand the flow through the
> code and find the problem but haven't been successful.
> 
> Would a saavy Samba technical person be willing to work with me on
> resolving this?  I have logs and data but lacking an obvious focal point
> for the problem I can't summarize the logs enough to include them in
> this message.

Here is the fix for Samba 2.2.8 to make MS-DFS work again with WinXP.
(For once this wasn't my fault :-).

Sorry for the problem,

	Jeremy.

Index: smbd/trans2.c
===================================================================
RCS file: /data/cvs/samba/source/smbd/trans2.c,v
retrieving revision 1.149.4.98
diff -u -r1.149.4.98 trans2.c
--- smbd/trans2.c       7 Mar 2003 23:35:00 -0000       1.149.4.98
+++ smbd/trans2.c       25 Mar 2003 23:36:05 -0000
@@ -3043,7 +3043,7 @@
 {
        char *params = *pparams;
        enum remote_arch_types ra_type = get_remote_arch();
-       BOOL NT_arch = ((ra_type == RA_WINNT) || (ra_type == RA_WIN2K));
+       BOOL NT_arch = ((ra_type == RA_WINNT) || (ra_type == RA_WIN2K) || (ra_type == RA_WINXP) || (ra_type == RA_WIN2K3));
        pstring pathname;
        int reply_size = 0;
        int max_referral_level;