Error messages generated by passdb/pdb_smbpasswd.c are (almost) useless

[Simo Sorce]

It seem very clear to me Richard.

An smbpasswd entry has a single UID field, if there you find something
that's not a number then the entry is malformed.

What's unclear?

Printing the line may clobber the logs, as a malformed entry may contain
just anything like control chars, I agree that telling the entry line
number could be a good idea.

Simo.

On Fri, 2003-03-14 at 07:55, Richard Sharpe wrote:
> Hi,
> 
> Someone asked me what some messages like "getsmbfilepwent: malformed 
> password entry (uid not number)" meant when using the smbpasswd command. 
> Not knowing, I went searching the source code to find:
> 
>     if (!isdigit(*p)) {
>       DEBUG(0, ("getsmbfilepwent: malformed password entry (uid not 
> number)\n"));
>       continue;
> 
> This is very little help in pinpointing the problems, as it does not tell 
> us what the routine was looking at that caused the problem. Perhaps 
> including the string it was processing would have been more useful!
>  
> Regards
> -----
> Richard Sharpe, rsharpe[at]ns.aus.com, rsharpe[at]samba.org, 
> sharpe[at]ethereal.com, http://www.richardsharpe.com
-- 
Simo Sorce - simo.sorce at xsec.it
Xsec s.r.l. - http://www.xsec.it
via Durando 10 Ed. G - 20158 - Milano
mobile: +39 329 328 7702
tel. +39 02 2399 7130 - fax: +39 02 700 442 399
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 232 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20030314/7eaf6cec/attachment.bin