bug or typo in smbd/service.c: make_connection_snum(line 530)?

[Chere Zhou]

Thanks for the explanation.  That helps.


On Tuesday 11 March 2003 12:52 am, Andrew Bartlett wrote:
> On Tue, 2003-03-11 at 12:16, Chere Zhou wrote:
> > The block reads:
> >
> >         if (conn->force_user || conn->force_group) {
> >
> >                 /* groups stuff added by ih */
> >                 conn->ngroups = 0;
> >                 conn->groups = NULL;
> >
> >                 /* Find all the groups this uid is in and
> >                    store them. Used by change_to_user() */
> >                 initialise_groups(conn->user, conn->uid, conn->gid);
> >                 get_current_groups(conn->gid,
> > &conn->ngroups,&conn->groups);
> >
> >                 conn->nt_user_token = create_nt_token(conn->uid,
> > conn->gid, conn->ngroups, conn->groups,
> >                                                       guest);
> >         }
> >
> > I think the if should be ( ! (conn->force_user || conn->force_group)), 
> > since the force_user and force_group processing should be all done just
> > before this block of code.  Otherwise I don't understand the logic here.
> >
> > I think this is related to my earlier posting with the subject of "3.0a21
> > and HEAD: only primary group of a domain user is set on smbd".
>
> If force_user or force_group is not set, then we don't use these
> values.  Instead we use the values attached to the vuid.
>
> Andrew Bartlett