Another way to fix pdbedit segfaults in Samba 3.0

Jianliang Lu j.lu at tiesse.com
Thu Mar 6 13:10:59 GMT 2003


As we know, the pdbedit from samba3.0 alpha21 got segfaults when you don't
give the user_name. There is a fix about this on the CVS, but I think that 
the fix does not do that the pdbedit should do, that means, if you don't 
give the user_name the tool should show all users, but not exit like the fix 
did.
I've fixed the problem in another way, that if you run pdbedit without a 
user_name it show all users, otherway, it show the user that you sepcified.
I have tested it and it worked!

The patch is following: (the pdbedit.c.rel is that from samba team)

--- pdbedit.c.rel   Thu Mar  6 13:30:16 2003
+++ pdbedit.c   Thu Mar  6 13:30:43 2003
@@ -494,9 +494,6 @@

    poptGetArg(pc); /* Drop argv[0], the program name */

-   if (user_name == NULL) {
-       user_name = strdup(poptGetArg(pc));
-   }

    if (!lp_load(dyn_CONFIGFILE,True,False,False)) {
        fprintf(stderr, "Can't load %s - run testparm to debug it\n", 
dyn_CONFIGFILE);

Jianliang Lu
TieSse s.p.a.
j.lu at tiesse.com
luj at libero.it


More information about the samba-technical mailing list