[PATCH] draft: better string overflow checking (was: memory corruption in SAMBA_3_0)

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wed, 5 Mar 2003, Martin Pool wrote:

> I was thinking about Andrew's fstring-overflow patch from a few weeks
> ago: for developer builds, it touches the last byte of a string buffer
> to check that it's as long as it should be.  
> 
> This should be reasonably helpful in catching string overflows on the
> heap, but not so good on the stack, because the program can probably
> write arbitrarily far past stack variables without trapping, even
> under Valgrind.  Writing a \0 in there will damage *something* and
> probably make the program crash, but it won't be very obvious.  I
> think this might have been what Jerry saw the other day.

This looks good Martin.  Would be much easier to catch when we write past 
the end.  You've got my vote.




cheers, jerry
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.0 (GNU/Linux)
Comment: For info see http://quantumlab.net/pine_privacy_guard/

iD8DBQE+ZiIzIR7qMdg1EfYRAs/0AKDJRVt1giqVvWCdEAns40uaDD9bjACg7pxw
pkOgMnGRHXrSvqwGsRh5+Ts=
=MnXj
-----END PGP SIGNATURE-----