Simplify idmap.c?

Jeremy Allison jra at
Mon Jun 30 21:05:39 GMT 2003

On Mon, Jun 30, 2003 at 10:46:15PM +0200, Volker Lendecke wrote:
> Hi!
> In trying to understand a remote idmap, I found a bug in current
> idmap.c. Line 165 needs a 'ret ='...
> Pursuing the idea that given a remote idmap our local tdb one is just a
> cache can simplify idmap.c a lot. See attached patch. As I said, I don't
> like nested if's :-)
> I think even the idmap_set_mapping is sane looking at all the places
> that still call this.

I like this patch. I'm going to test it out and commit it (if that's


More information about the samba-technical mailing list