order of idmap backends

[Simo Sorce]

On Wed, 2003-06-25 at 22:51, Jeremy Allison wrote:
> On Wed, Jun 25, 2003 at 10:39:14PM +0200, Stefan (metze) Metzmacher wrote:
> > At 20:32 25.06.2003 +0000, Jeremy Allison wrote:
> > >On Wed, Jun 25, 2003 at 10:24:06PM +0200, Stefan (metze) Metzmacher wrote:
> > > > Hi Jeremy,
> > > >
> > > > why did you change DLIST_ADD() to DLIST_ADD_END() ?
> > > >
> > > > in smb_register_idmap()
> > > >
> > > > why is the order important?
> > > >
> > > > we should have this in sync with the other smb_register_*() functions!!!
> > >
> > >Because I thought the order was important. It *should* be !
> > >This is very broken right now....
> > 
> > I think it's not impartant and also should not be important!!!
> > (we just search in a linked list and it doesn't matter on which position 
> > and list element is!)
> > 
> > and I can't see were it's broken.
> 
> Because smbd should be asking winbind, not doing anything directly
> in idmap. winbind should be looking in the tdb, with ldap as a remote
> backend.
> 
> This code has been written to be generic, when it *ISN'T* generic.
> The is and should be an ordering in this.
> 
> Don't worry, Jerry and I are going to fix this....

I'm worrying a lot ... look at the code it is yet order dependent.

and here it is one of the drawings I've done some moths ago to explain
how idmap works:
http://dp.samba.org/~idra/pubdir/idmap_winbind_no_loop.png

May be a bit outdated, but it is on of the bases on which I made my
idmap code.

Simo.

-- 
Simo Sorce - simo.sorce at xsec.it
Xsec s.r.l. - http://www.xsec.it
via Durando 10 Ed. G - 20158 - Milano
mobile: +39 329 328 7702
tel. +39 02 2399 7130 - fax: +39 02 700 442 399
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20030626/a35724e6/attachment.bin