[PATCH] fix VFS MACROS again...

Stefan (metze) Metzmacher metze at metzemix.de
Fri Jun 6 06:15:49 GMT 2003

At 05:58 06.06.2003 +0000, jra at dp.samba.org wrote:
>On Fri, Jun 06, 2003 at 07:55:51AM +0200, Stefan (metze) Metzmacher wrote:
> > Hi Jeremy,
> >
> > your EA patch introduces bugs into vfs_macros.h
> >
> > the SMB_VFS_NEXT_* macros are not only cut-n-paste!
> >
> > Please be a bit more careful (so close to release)
> >
> > The best is to add new vfs functions to the skel_*.c modules
> > and test if it compiles fine.
>So can you explain exactly what the differences are
>in the VFS_NEXT - it's not listed in the include file
>and is not obvious.

for the SMB_VFS_* and SMB_VFS_OPAQUE_*

it's allways rename "SMB_VFS_ " to "SMB_VFS_OPAQUE_"
and "->vfs."  to "->vfs_opaque."

but for SMB_VFS_NEXT_*

you need to take care of the function which got fsp not conn.

so (handle)->conn->vfs_next doesn't exist.
it's just always (handle)->vfs_next.

(like in the patch I sended to you :-)

>We need this (EA) functionality to do the ACLs right,
>so I'd rather annoy the Samba developers now, than the
>customers later :-).

Stefan "metze" Metzmacher <metze at metzemix.de> 

More information about the samba-technical mailing list