[PATCH] fix VFS MACROS again...

jra at dp.samba.org jra at dp.samba.org
Fri Jun 6 05:58:29 GMT 2003


On Fri, Jun 06, 2003 at 07:55:51AM +0200, Stefan (metze) Metzmacher wrote:
> Hi Jeremy,
> 
> your EA patch introduces bugs into vfs_macros.h
> 
> the SMB_VFS_NEXT_* macros are not only cut-n-paste!
> 
> Please be a bit more careful (so close to release)
> 
> The best is to add new vfs functions to the skel_*.c modules
> and test if it compiles fine.

So can you explain exactly what the differences are
in the VFS_NEXT - it's not listed in the include file
and is not obvious.

We need this (EA) functionality to do the ACLs right,
so I'd rather annoy the Samba developers now, than the
customers later :-).

Jeremy.



More information about the samba-technical mailing list