[PATCH] Allow . to end a filename, use real unicode for fnmatch().

Andrew Bartlett abartlet at samba.org
Sun Jul 27 09:16:52 GMT 2003

On Sun, 2003-07-27 at 17:33, Andrew Bartlett wrote:
> On Sun, 2003-07-27 at 16:43, Jeremy Allison wrote:
> > On Sun, Jul 27, 2003 at 03:20:52PM +1000, Andrew Bartlett wrote:
> > > 
> > > In testing this patch however, I noticed that our mangling code was
> > > refusing to allow filenames that end in '.'   This caused us to fail our
> > > own tests (or the Samba 2.2 tests actually).
> > > 
> > > So, I tested Win2k - and it allows filenames to end in .  (as in
> > > 'foo.'), so I've removed this part of the code.
> > 
> > WARNING !!!!!!! TEST THIS EXTENSIVELY - don't just commit. You don't
> > have historical context on this. W2K does not allow this on a filesystem,
> > it silently truncates the terminating dot from the filename.
> Does it?
> Using smbclient, I can 'put foo.' and 'put Makefile', and get them both
> using *only* their original names (adding/deleting dots).
> > Please forward this part of the patch to me for review.
> Attached.  The reason I sent my original patch 'to' you was that it is a
> direct reversion of your earlier patch removing 'strip dot'.  However,
> that was on the basis that a terminating dot is an invalid name, which
> does not seem to be the case with my Win2000 SP4 test server.

Given your response, I assume this was an unexpected outcome - I'll note
that I have installed 'services for unix 3.0' (including the NFS server)
onto box, so that may have changed file-system semantics.

Andrew Bartlett

Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20030727/b86c592e/attachment.bin

More information about the samba-technical mailing list