[PATCH] Allow . to end a filename, use real unicode for fnmatch().

Jeremy Allison jra at samba.org
Sun Jul 27 06:43:57 GMT 2003

On Sun, Jul 27, 2003 at 03:20:52PM +1000, Andrew Bartlett wrote:
> In testing this patch however, I noticed that our mangling code was
> refusing to allow filenames that end in '.'   This caused us to fail our
> own tests (or the Samba 2.2 tests actually).
> So, I tested Win2k - and it allows filenames to end in .  (as in
> 'foo.'), so I've removed this part of the code.

WARNING !!!!!!! TEST THIS EXTENSIVELY - don't just commit. You don't
have historical context on this. W2K does not allow this on a filesystem,
it silently truncates the terminating dot from the filename.

Please forward this part of the patch to me for review.

This is the big problem with the proposed "patch review"
process. There's not garentee that someone is reviewing everything,
I've been neck-deep in signing code for the part week and
have not had time to review any of these changes, and this
close to release this is *dangerous*.


More information about the samba-technical mailing list