CVS update: samba/source/lib

Jeremy Allison jra at
Sun Jul 27 06:35:04 GMT 2003

On Sun, Jul 27, 2003 at 01:24:34PM +1000, Tim Potter wrote:
> On Sun, Jul 27, 2003 at 02:28:25AM +0000, abartlet at wrote:
> > Modified Files:
> >       Tag: SAMBA_3_0
> > 	charcnv.c 
> > Log Message:
> > Some small fixes to our charset conversion code:
> > 
> >  - Treat the NMB names in the 'session request' packet as 'ASCII'.  This means
> >    that we do not get invalid multibyte from the wire, even if we truncate
> >    in the conversion.  (Otherwise we panic when we try to strupper_m it).
> This will probably break netbios names containing international
> characters.  Unfortunately Netbios names are in the dos codepage of the
> client so there isn't a lot left to break (-: but it is supposed to work
> amongst clients with identical dos codpages.

Yes - please revert this for NetBIOS names (in the libnmb code).
This *will* break multibyte NetBIOS names (which people do use,
lots of the HP testing was around this). We need to fix the panic
in strupper_m another way.


More information about the samba-technical mailing list