[PATCH] set DefaultSpoolDirectory = "C:\\PRINTERS"

Gerald (Jerry) Carter jerry at samba.org
Fri Jul 25 13:29:13 GMT 2003


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Fri, 25 Jul 2003, Stefan (metze) Metzmacher wrote:

> Hi Jerry,
> 
> here's a small patch to setup the DefaultSpoolDirectory for the 
> PRINTER_HANDLE_IS_PRINTSERVER case.
> 
> I think this doesn't belong to lp_serverstring() !!!
> 
> as we return static values for all parameters, I think it's ok to just 
> return "C:\\PRINTERS"...
> 
> and using
> const char *string ="Windows NT x86";
> 
> is much better then using;
> 
> pstring string = "Windows NT x86"; :-)
> 
> I also add the
> 
> PRINTER_HANDLE_IS_PRINTSERVER => return WERR_INVALID_PARAM
> 
> if the PRINTER_HANDLE_IS_PRINTSERVER case is not implemented...

Looks good to me.  Applying it.




cheers, jerry
 ----------------------------------------------------------------------
 Hewlett-Packard            ------------------------- http://www.hp.com
 SAMBA Team                 ---------------------- http://www.samba.org
 GnuPG Key                  ---- http://www.plainjoe.org/gpg_public.asc
 "You can never go home again, Oatman, but I guess you can shop there."  
                            --John Cusack - "Grosse Point Blank" (1997)

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.0 (GNU/Linux)
Comment: For info see http://quantumlab.net/pine_privacy_guard/

iD8DBQE/ITCpIR7qMdg1EfYRAuXvAKDQ8ED+IcDI0osKJZ/n9/92efmynQCfS9Ov
ENRV+9FlgZbu9a84G/pYuT4=
=nzTL
-----END PGP SIGNATURE-----




More information about the samba-technical mailing list