[patch] Allow explicit user mappings via net command

Stefan (metze) Metzmacher metze at metzemix.de
Fri Jul 25 05:19:08 GMT 2003


At 15:21 24.07.2003 -0400, ZINKEVICIUS,MATT (HP-Loveland,ex1) wrote:
>This patch adds a unmap command to the idmap module interface and implements
>it for the tdb idmap backend. Also adds 3 new net commands:

two comments :

- if something is not implemented, please use NT_STATUS_NOT_IMPLEMENTED 
instead of NT_STATUS_UNSUCCESSFUL

- it has no effect to just remove a mapping in the remote backend, when 
it's still in the local cache.

so a logic like this would be better:

idmap_remove_mapping(DOMSID *psid)
{
         cache_map->remove_mapping(psid);

         if (remote_map) {
                 remote_map->remove_mapping(psid);
         }
}


metze
-----------------------------------------------------------------------------
Stefan "metze" Metzmacher <metze at metzemix.de> 




More information about the samba-technical mailing list