tagged the head branch

Alexander Bokovoy a.bokovoy at sam-solutions.net
Wed Jul 16 09:07:31 GMT 2003


On Wed, Jul 16, 2003 at 10:20:19AM +0200, Volker Lendecke wrote:
> On Tue, Jul 15, 2003 at 12:56:49PM -0500, Gerald (Jerry) Carter wrote:
> > Would you mind doing the patch?
> 
> Attached is an attempt to blacklist glibc <= 2.3. I have tested this
> under Linux, I don't have any other system currently available.
> 
> As this is my first attempt to touch configure.in, can somebody else
> test this to at least run?
I would rather modify this test to see actual brokeness of glibc <=2.3
because vendors might definitely patch their versions with this simple
patch from glibc:

===================================================================
RCS file: /cvs/glibc/libc/grp/initgroups.c,v
retrieving revision 1.28
retrieving revision 1.29
diff -u -r1.28 -r1.29
--- libc/grp/initgroups.c	2002/03/13 17:51:09	1.28
+++ libc/grp/initgroups.c	2003/04/23 21:26:34	1.29
@@ -1,4 +1,4 @@
-/* Copyright (C) 1989,91,93,1996-2001, 2002 Free Software Foundation, Inc.
+/* Copyright (C) 1989,91,93,1996-2002, 2003 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
 
    The GNU C Library is free software; you can redistribute it and/or
@@ -23,6 +23,7 @@
 #include <stdlib.h>
 #include <string.h>
 #include <unistd.h>
+#include <sys/param.h>
 #include <sys/types.h>
 #include <nsswitch.h>
 
@@ -207,6 +208,9 @@
     return -1;
 
   result = internal_getgrouplist (user, group, &size, &newgroups, -1);
+
+  memcpy (groups, newgroups, MIN (*ngroups, result) * sizeof (gid_t));
+
   if (result > *ngroups)
     {
       *ngroups = result;
@@ -215,8 +219,6 @@
   else
     *ngroups = result;
 
-  memcpy (groups, newgroups, *ngroups * sizeof (gid_t));
-
   free (newgroups);
   return result;
 }

-- 
/ Alexander Bokovoy



More information about the samba-technical mailing list