[PATCH] Clean up cli_pipe to find the auth footer once only.

Gerald (Jerry) Carter jerry at samba.org
Wed Jul 16 03:03:37 GMT 2003

Hash: SHA1

On Wed, 16 Jul 2003, Andrew Bartlett wrote:

> > Modified Files:
> >       Tag: SAMBA_3_0
> > 	cli_pipe.c 
> > Log Message:
> > fix schannel processing on fragmented PDUs.  'net rpc vampire' works again.
> Thankyou very much for finding this - my test domain didn't seem to give
> me the fragmentated PDUs.

no problem.  You owe me 2 hours though :-)  You must have a very small 
domain.  I have about 4 users and as many groups.

> I've tried to fix this for the generic case - it looks like the NTLMSSP case 
> never coped with fragmented PDUs, hence the introduction of this bug.
> What I'm trying to do in the attached patch is ensure we try to find the
> authentication footer only once...
> Could you please check this against your test domains?

Seems ok.  The only thing I see is 

  SCHANNEL ERROR: seq_num must be even in client (seq_num=3)
  SCHANNEL seq_num=3
  SCHANNEL: netsec_encode seq_num=3 data_len=104

But this was here before.  users and groups decode properly.
I'm only testing the schannel stuff though.  I'm not paying attention
to much else.  

So as long as the domain migration still works (which it does) 
and domain joins are ok, then let's put this in for beta3.
I'm starting on beta3 now so please go ahead and check this in.

cheers, jerry
Version: GnuPG v1.2.0 (GNU/Linux)
Comment: For info see http://quantumlab.net/pine_privacy_guard/


More information about the samba-technical mailing list