CVS update: samba/source/rpc_server
jra at samba.org
Wed Jul 9 05:57:19 GMT 2003
On Wed, Jul 09, 2003 at 05:35:59AM +0000, Andrew Bartlett wrote:
> It's not leaking memory becouse it was allocated on the talloc context.
> But the memory from the original SAM_ACCOUNT is not refereced, except by
> the talloc context.
I know. I analysed it.
> My main problem is with calling pdb_free_sam() on a pointer not created by
> pdb_init_sam() - it breaks the abstraction of the SAM_ACCOUNT.
> Would you mind if I cleaned up that code to handle this?
It doesn't break the SAM_ACCOUNT abstraction as the sam account code
explicitly has a 'create using this tdb' call which is used here.
Please don't change the code as I am happy with it. If you can't
stop yourself just mail me a proposed patch - but I'm going to
be in Portland tomorrow and thursday (back friday) so I may
not get to it until then.
More information about the samba-technical