AW: [PATCH] better ldap,krb5,ads detection (fix bug #125)

[mx at metzemix.de]

 --- Ursprüngliche Nachricht --- 
Datum: 04.07.2003 20:01
Von: Steve Langasek <vorlon at netexpress.net>
An: "Stefan (metze) Metzmacher" <metze at metzemix.de>
Betreff: Re: [PATCH] better ldap,krb5,ads detection (fix bug #125)
  
> Hi Stefan,
> 
> On Fri, Jul 04, 2003 at 08:52:24AM +0200, Stefan (metze) Metzmacher
wrote:
> > At 17:00 01.07.2003 +0200, Stefan (metze) Metzmacher wrote:
> > >HI *
> > >
> > >here's the final patch for fixing bug #125
> > >
> > >and also fixes some other linking bugs
> > >
> > >kai has tested this on his system
> > >
> > >with different --with-ldap=(yes/auto/no) --with-ads=(yes/auto/no)

> > >combinations
> 
> > Again :-)
> 
> > here's a new diff so that it applies fine again...
> 
> There are three problems I'm trying to fix with the existing krb5
> handling in configure.in:
> 
> - KRB5LIBS is tainted with the contents of CFLAGS, because
> krb5-config copies the contents of this variable into its output
> - Most of the Kerberos lib checks duplicate the purpose of krb5-config
In my patch the AC_CHECK_LIB_EXT() check only adds the lib when it's not
allready in KRB5_LIBS, so the output of krb5-config will not be extended
with other -lkrb5 ... add the end.

> - The libgssapi checks aren't duplicates, but they place
-lgssapi[_krb5]
> at the end of the list -- when it should actually be the /second/ item
> in the list, right after the -L<dir> entry
I checnged the 'krb5-config --libs' to 'krb5-config --libs gssapi'
then the gssapi[_krb5] lib is now in the right place.
(when we have krb5-config)

Please note that this patch should only clean up the tests and shouldn't
change the behavior.

This should go into a later patch, if needed.

So that it's easier to review for someone else.

> The first problem breaks the python build scripts, and the last two
mean
> that the library link list used is wrong on all platforms -- on
> platforms like Linux it contains lots of redundant information,
> resulting in overlinked binaries, and on platforms using static libs
(or
> weak sharedlib implementations), the libs are listed out of order,
which
> can cause resolution of library symbols to fail.
> 
> Do you have plans to address these problems in your patch?  The first
> I can see is not currently addressed (it can be fixed by running
> LIBS="`CFLAGS='' $KRB5_CONFIG --libs` $LIBS"), but it's hard to tell

> from looking at the patch whether you've made a difference for the
> last two issues.  I'd test it myself, but my build tree is currently
> dirty with the contents of my own work in this area. :-)

I don't really understand what's the problem is here?

I'll take a look at that next week.

It would be cool if you could test my patch against a clean samba tree.
And check what problems are still there.
(I hope I do not add new problems :-)

metze