[PATCH] better ldap,krb5,ads detection (fix bug #125)

[Steve Langasek]

Hi Stefan,

On Fri, Jul 04, 2003 at 08:52:24AM +0200, Stefan (metze) Metzmacher wrote:
> At 17:00 01.07.2003 +0200, Stefan (metze) Metzmacher wrote:
> >HI *
> >
> >here's the final patch for fixing bug #125
> >
> >and also fixes some other linking bugs
> >
> >kai has tested this on his system
> >
> >with different --with-ldap=(yes/auto/no) --with-ads=(yes/auto/no)
> >combinations

> Again :-)

> here's a new diff so that it applies fine again...

There are three problems I'm trying to fix with the existing krb5
handling in configure.in:

- KRB5LIBS is tainted with the contents of CFLAGS, because
  krb5-config copies the contents of this variable into its output
- Most of the Kerberos lib checks duplicate the purpose of krb5-config
- The libgssapi checks aren't duplicates, but they place -lgssapi[_krb5]
  at the end of the list -- when it should actually be the /second/ item
  in the list, right after the -L<dir> entry

The first problem breaks the python build scripts, and the last two mean
that the library link list used is wrong on all platforms -- on
platforms like Linux it contains lots of redundant information,
resulting in overlinked binaries, and on platforms using static libs (or
weak sharedlib implementations), the libs are listed out of order, which
can cause resolution of library symbols to fail.

Do you have plans to address these problems in your patch?  The first
I can see is not currently addressed (it can be fixed by running
LIBS="`CFLAGS='' $KRB5_CONFIG --libs` $LIBS"), but it's hard to tell
from looking at the patch whether you've made a difference for the
last two issues.  I'd test it myself, but my build tree is currently
dirty with the contents of my own work in this area. :-)

Cheers,
-- 
Steve Langasek
postmodern programmer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20030704/eb380a61/attachment.bin