Problems in configure.in re testing for iconv ...

Richard Sharpe rsharpe at richardsharpe.com
Tue Jul 1 22:19:25 GMT 2003


Here is what we do in configure.in:

LOOK_DIRS="/usr /usr/local /sw"
...
ICONV_FOUND="no"
for i in $LOOK_DIRS ; do
    LDFLAGS="-L$i/lib"
...
dnl Try to find iconv(3)
    jm_ICONV($i)

    CPPFLAGS=$save_CPPFLAGS
    if test -n "$ICONV_FOUND" ; then
        ...
        break
    else
        LDFLAGS=$save_LDFLAGS
        LIBS=$save_LIBS
        export LDFLAGS LIBS CPPFLAGS
    fi
done

Now, test -n tests for a non-zero string, but "no" is a non-zero string, 
so the loop will look no further than the first directory in LOOK_DIRS ... 

If there is some agreement that this is wrong, I will submit a patch.

Regards
-----
Richard Sharpe, rsharpe[at]ns.aus.com, rsharpe[at]samba.org, 
sharpe[at]ethereal.com, http://www.richardsharpe.com




More information about the samba-technical mailing list