CVS update: samba/source/passdb

[Andrew Bartlett]

On Tue, 2003-07-01 at 14:26, Gerald (Jerry) Carter wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 1 Jul 2003, Andrew Bartlett wrote:
> 
> > I would love to see the specific example of how get_global_sam_name()
> > (rather than one of the callers) was broken.  The other changes all
> > looked pretty sane (or understandable until we get the trustdom cache
> > working), but this one just looked odd.   That's why I replied to the
> > commit message.  
> 
> You told me to use get_global_sam_name() in make_user_info_map() remember?
> But it always mapped unknown users to our local netbios name instead
> of domain name like a windows server would.  Remember the test volker ran 
> on IRC about 12 hours ago?  

I remember the test - and thought we came to the opposite result, hence
the recommendation.  The code as it stands is how I would expect it to
be - and if that is what the testing showed then great.  All I can say
in my defence it that it was about 1am my time...

> > I think what we need is a get_default_domain_name() call, that does what
> > get_global_sam_name() now does.
> 
> Already fixed dude.  Update your cvs tree.

Thankyou very much - particularly for the comments explaining what each
does.  I'm sorry the lack of clear documentation contributed to the
original confusion.

Andrew Bartlett

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Manager, Authentication Subsystems, Samba Team  abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20030701/171e8167/attachment.bin